bug#66982: 30.0.50; Cannot delete bookmark of inaccessible remote file

[Michael Albinus]

Liu Hui <liuhui1610@gmail.com> writes:

Hi,

> Recipe:
>
> 1. Save the following text as the test bookmark file
>
> ;;;; Emacs Bookmark Format Version 1;;;; -*- coding: utf-8-emacs;
> mode: lisp-data -*-
> ;;; This format is meant to be slightly human-readable;
> ;;; nevertheless, you probably don't want to edit it.
> ;;; -*- End Of Bookmark File Format Version Stamp -*-
> (("test" (filename . "/ssh:192.168.0.100:~/") (front-context-string)
>  (rear-context-string . "g-style=literal\n") (position . 68)
>  (last-modified 25595 64776 373828 978000)))
>
> 2. emacs -Q --eval '(setq bookmark-default-file xxx)' -f list-bookmarks
>
> 3. press d, then x.
>
> However, the bookmark cannot be deleted because Emacs hangs or displays
> tramp error message/popup window after several seconds.

Thank you for the recipe, I can reproduce the problem. It happens,
because in `bookmark--remove-fringe-mark' there is a call of
`expand-file-name', which blocks if a remote file is not reachable.

Could you pls check the appended patch? It fixes your recipe for me, and
shouldn't harm other use cases.

Best regards, Michael.

txt9V3yJRdBwV.txt
Description: Text Data