[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66993: [PATCH] project.el: avoid asking user about project-list-file
From: |
Eli Zaretskii |
Subject: |
bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock |
Date: |
Thu, 09 Nov 2023 18:52:19 +0200 |
> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: dmitry@gutov.dev, 66993@debbugs.gnu.org
> Date: Thu, 09 Nov 2023 11:38:26 -0500
>
> > That's one way, yes. Another one is to use define-error to define a
> > new error type for this case.
>
> Instead of defining a new error type, how about just signaling
> file-locked instead? e.g. the following patch:
>
> diff --git a/lisp/userlock.el b/lisp/userlock.el
> index 61f061d3e54..e4d23c56249 100644
> --- a/lisp/userlock.el
> +++ b/lisp/userlock.el
> @@ -67,7 +67,7 @@ ask-user-about-lock
> (message (substitute-command-keys
> "%s locked by %s: (\\`s', \\`q', \\`p', \\`?')? ")
> short-file short-opponent)
> - (if noninteractive (error "Cannot resolve lock conflict in batch mode"))
> + (if noninteractive (signal 'file-locked (list file opponent)))
> (let ((tem (let ((inhibit-quit t)
> (cursor-in-echo-area t))
> (prog1 (downcase (read-char))
Please show the result of this change on what Emacs prints in batch
mode when this error is signaled.
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, (continued)
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Dmitry Gutov, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Spencer Baugh, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Spencer Baugh, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Spencer Baugh, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/09
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Spencer Baugh, 2023/11/09
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock,
Eli Zaretskii <=
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Spencer Baugh, 2023/11/09
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/09
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Spencer Baugh, 2023/11/10
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/15
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Spencer Baugh, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Dmitry Gutov, 2023/11/08
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/09
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Dmitry Gutov, 2023/11/09
- bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock, Eli Zaretskii, 2023/11/09