bug#66982: 30.0.50; Cannot delete bookmark of inaccessible remote file

[Liu Hui]

Michael Albinus <michael.albinus@gmx.de> 于2023年11月8日周三 16:40写道：

> Thank you for the recipe, I can reproduce the problem. It happens,
> because in `bookmark--remove-fringe-mark' there is a call of
> `expand-file-name', which blocks if a remote file is not reachable.
>
> Could you pls check the appended patch? It fixes your recipe for me, and
> shouldn't harm other use cases.

Thank you! I confirm it works.

BTW, I find binding non-essential to t fixes a similar problem caused
by abbreviate/expand-file-name on remote files:

1. save the following text to file A:

;;; -*- coding: utf-8; mode: lisp-data -*-
(("/ssh:192.168.0.100:~/a.txt" . 282))

2. emacs -Q --eval '(setq save-place-file <file A>)' -f save-place-mode


diff --git a/lisp/saveplace.el b/lisp/saveplace.el
index 590c55d2609..2dda3b4d44b 100644
--- a/lisp/saveplace.el
+++ b/lisp/saveplace.el
@@ -156,7 +156,8 @@ save-place-abbreviate-file-names
   :set (lambda (sym val)
          (set-default sym val)
          (or save-place-loaded (save-place-load-alist-from-file))
-         (let ((fun (if val #'abbreviate-file-name #'expand-file-name)))
+         (let ((non-essential t)
+               (fun (if val #'abbreviate-file-name #'expand-file-name)))
            (setq save-place-alist
                  (cl-delete-duplicates
                   (cl-loop for (k . v) in save-place-alist