bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67062: 30.0.50; [PATCH] Abbreviate the revision in 'vc-annotate' (fo


From: Jim Porter
Subject: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in 'vc-annotate' (for Git)
Date: Sun, 12 Nov 2023 14:15:20 -0800

On 11/12/2023 12:35 PM, Dmitry Gutov wrote:
On 12/11/2023 21:07, Jim Porter wrote:
In any case, we don't necessarily need to provide a default implementation for the 'short-revision' function. What about something like this? I'm not sure it's better, but it does let us avoid defining a no-op implementation for the "default backend".

Looks worse to me than having the default "identity" implementation.

Sorry.

Though it might go in anyway, since Eli likes it.

I'll do whichever gets the patch merged. While I personally find the no-op implementation for the default backend to be cleaner, doing it the other way doesn't bother me enough that I'll fight for it.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]