[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#67323: 30.0.50; [PATCH] Set a new desktop file to mode 0600
From: |
Manuel Giraud |
Subject: |
bug#67323: 30.0.50; [PATCH] Set a new desktop file to mode 0600 |
Date: |
Tue, 21 Nov 2023 14:00:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Tue, 21 Nov 2023 11:23:56 +0100
>> From: Manuel Giraud via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> As a desktop file can contain some "secret" data, I think it is better
>> to make it read/write only to the user by default. This does not
>> prevent the user to later change the mode of this desktop file if he
>> wants to "share" it.
>
> We don't do this in other cases, AFAICT, so why do it here?
Hi Eli,
I had this idea while browsing savehist.el. It have
'savehist-file-modes' set to #o600 by default. Since desktop.el could
also contain histories or others "secrets", I thought that it may a good
idea to have more strict default.
> The users can make this file unreadable by others if they want.
Yes and it is what I have done previously for my own desktop file. The
idea here is to have saner default. And as I said, it also works the
other way around ;-)
> It's a backward-incompatible change in any case.
You are saying that it might surprise users who rely on the "readable
for all" nature of one desktop file by default? I'd have a hard time to
figure out such a scenario… But anyway, if you think this patch does
not worth it, say it and I'll close this report.
Thanks,
--
Manuel Giraud