bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67005: 30.0.50; improve nadivce/comp/trampoline handling


From: Eli Zaretskii
Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling
Date: Thu, 23 Nov 2023 08:19:04 +0200

> Cc: andrea corallo <acorallo@gnu.org>, 67005@debbugs.gnu.org
> Date: Wed, 22 Nov 2023 23:01:44 +0100
> From:  Jens Schmidt via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
> index 42027c01491..c43d1b86752 100644
> --- a/lisp/emacs-lisp/nadvice.el
> +++ b/lisp/emacs-lisp/nadvice.el
> @@ -507,10 +507,15 @@ advice-add
>  is defined as a macro, alias, command, ...
>  HOW can be one of:
>  <<>>"
> +  ;; Actively disallow function advices during bootstrap for the
> +  ;; following reasons:
> +  ;; - Advices in Emacs' core are generally considered bad style.
> +  ;; - `Snarf-documentation' looses docstrings of advised dumped
> +  ;;   functions (bug#66032#20).
>    ;; TODO:
>    ;; - record the advice location, to display in describe-function.
> -  ;; - change all defadvice in lisp/**/*.el.
> -  ;; - obsolete advice.el.

Does this patch resolve the 2 TODO items you are now deleting?  Or
were they already resolved by previous changes, and we just failed to
keep the comments up-to-date?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]