[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#67275: [PATCH] ; Improve and add tests for Completion Preview mode
From: |
Eli Zaretskii |
Subject: |
bug#67275: [PATCH] ; Improve and add tests for Completion Preview mode |
Date: |
Sat, 25 Nov 2023 12:12:49 +0200 |
> From: Eshel Yaron <me@eshelyaron.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 67275@debbugs.gnu.org
> Date: Mon, 20 Nov 2023 13:26:45 +0100
>
> Eshel Yaron writes:
>
> > ...Here's the updated patch...
>
> I'm attaching below another patch, which is meant to be applied on top
> of the patch from my previous message.
>
> This patch simplifies Completion Preview mode a bit and, crucially,
> fixes an issue where certain `completion-at-point-functions`
> configurations could prevent `completion-preview-insert` from actually
> inserting the completion suggestion.
>
> I could unify this patch with the previous one and submit them as a
> single patch if that'd be preferable, although in terms of Git history
> it might be nicer to commit them separately IMO.
Thanks, installed on master.
Should we now close this bug?
P.S. Please make a point of mentioning the bug number as part of the
commit log messages, whenever you know the number. (The initial patch
that creates a bug report usually doesn't know the number, but
subsequent submissions do.)