bug#67275: [PATCH] ; Improve and add tests for Completion Preview mode

[Eshel Yaron]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Eshel Yaron <me@eshelyaron.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  67275@debbugs.gnu.org
>> Date: Mon, 20 Nov 2023 13:26:45 +0100
>> 
>> Eshel Yaron writes:
>> 
>> > ...Here's the updated patch...
>> 
>> I'm attaching below another patch, which is meant to be applied on top
>> of the patch from my previous message.
>> 
>> This patch simplifies Completion Preview mode a bit and, crucially,
>> fixes an issue where certain `completion-at-point-functions`
>> configurations could prevent `completion-preview-insert` from actually
>> inserting the completion suggestion.
>> 
>> I could unify this patch with the previous one and submit them as a
>> single patch if that'd be preferable, although in terms of Git history
>> it might be nicer to commit them separately IMO.
>
> Thanks, installed on master.

Great, thanks.

> Should we now close this bug?

Yes, I think so.  I have another patch in the works (making Completion
Preview mode more convenient for mouse users), but it's probably best to
start a separate thread for that.

> P.S. Please make a point of mentioning the bug number as part of the
> commit log messages, whenever you know the number.  (The initial patch
> that creates a bug report usually doesn't know the number, but
> subsequent submissions do.)

Sure, sorry for omitting it here.


Eshel