bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#66938: 30.0.50 [PATCH]: Make EIEIO :accessor behave like :reader whe


From: Brandon Irizarry
Subject: bug#66938: 30.0.50 [PATCH]: Make EIEIO :accessor behave like :reader when reading a slot's value
Date: Sat, 25 Nov 2023 22:21:21 -0500

Done. The patch is included with this email.

- Brandon

On Sat, Nov 25, 2023 at 9:57 AM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
[ Sorry for the delay, and thanks Eli for re-pinging me.  ]

> I've included a suggested patch for 'eieio.el', which slightly
> modifies the behavior of EIEIO's 'defclass'. When playing around with
> 'eieio-instance-inheritor' as a base class, I noticed that calls to
> the accessor (when used as a getter) weren't delegating to the parent
> instance (as defined when calling 'clone'). That is, an object clone that
> doesn't set
> its fields directly will report 'nil' when the accessor method is used as a
> getter for some slot.

The patch looks great and confirms my FIXME.

Could you turn the example in the commit message into a test in
test/lisp/emacs-lisp/eieio-tests/eieio-tests.el?


        Stefan

Attachment: 0001-Bug-66938-add-example-used-in-patch-commit-message-t.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]