PSPP-BUG: [bug #61256] heap-buffer-overflow in pspp at segment.c:137

[Irfan Ariq]

URL:
  <https://savannah.gnu.org/bugs/?61256>

                 Summary: heap-buffer-overflow in pspp at segment.c:137
                 Project: PSPP
            Submitted by: irfanariq
            Submitted on: Thu 30 Sep 2021 08:20:58 PM UTC
                Category: None
                Severity: 5 - Average
                  Status: None
             Assigned to: None
             Open/Closed: Open
                 Release: None
         Discussion Lock: Any
                  Effort: 0.00

    _______________________________________________________

Details:

Hello,

We are currently working on fuzz testing feature, and we found a
**heap-buffer-overflow** on `pspp`.

The stack traces are as follow:
```st
==29389==ERROR: AddressSanitizer: heap-buffer-overflow on address
0x60c000000900 at pc 0x7f3800a10365 bp 0x7ffec655dda0 sp 0x7ffec655dd90
READ of size 1 at 0x60c000000900 thread T0
    #0 0x7f3800a10364 in segmenter_parse_digraph__
src/language/lexer/segment.c:137
    #1 0x7f3800a14519 in segmenter_parse_mid_command__
src/language/lexer/segment.c:949
    #2 0x7f3800a17ecd in segmenter_push src/language/lexer/segment.c:1648
    #3 0x7f3800a09f98 in lex_source_get__ src/language/lexer/lexer.c:1376
    #4 0x7f3800a0546c in lex_get src/language/lexer/lexer.c:229
    #5 0x7f3800a0822a in lex_discard_rest_of_command
src/language/lexer/lexer.c:1114
    #6 0x7f3800a01ded in do_parse_command src/language/command.c:244
    #7 0x7f3800a01809 in cmd_parse_in_state src/language/command.c:147
    #8 0x7f3800a018d9 in cmd_parse src/language/command.c:162
    #9 0x55895cc19e30 in main src/ui/terminal/main.c:136
```
The full stack trace is attached.

**Step to reproduce**

We configured `pspp` using `CFLAGS="-g -O0 -fsanitize=address" CXXFLAGS="-g
-O0 -fsanitize=address" ./configure --prefix=$(pwd)/ --without-cairo
--without-perl-module` and built in using `make -j10`, and run it with:

```
./pspp -o /dev/null -O format=odt <attached file>
```
The input file is attached.

**Environment**
- OS: Ubuntu 18.04.5 LTS
- GCC version: gcc 7.5.0
- pspp version: [pspp
1.4.1](http://mirror.yongbok.net/gnu/pspp/pspp-1.4.1.tar.gz)

Thank you.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 30 Sep 2021 08:20:58 PM UTC  Name: full_stacktrace_poc_5.zip  Size:
1KiB   By: irfanariq

<http://savannah.gnu.org/bugs/download.php?file_id=52002>
-------------------------------------------------------
Date: Thu 30 Sep 2021 08:20:58 PM UTC  Name: input_pspp_poc_5.zip  Size: 372B 
 By: irfanariq

<http://savannah.gnu.org/bugs/download.php?file_id=52003>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61256>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/