Re: [Bug-gnubg] python/db issues + minor comment

[Christian Anthon]

On Thu, Mar 30, 2006 at 08:31:58AM +0200, address@hidden wrote:
> Latest news on win db stuff : it just works !!
> With latest gnubg.sql and gnubg.game.sql I can also switch game logging on.
> 
> 2 fixes are necessary (sorry, I don't have a std diff tool right
> now, I promise to get one asap; trying to manually emulate) :
> 
> 1- gtkgame.c, line 9907 :
> 
> >if (!GtkGetEnv(env))
> --
> <if (GtkGetEnv(env))

I think it is preferable to change the return values of GtkGetEnv for
readability.

> 
> 2- database.py, line 602 :
> 
> >sqlfile = open("gnubg.sql", "r")
> --
> <if self.games :
> <  sqlfile = open("gnubg.game.sql", "r")
> <else :
> <  sqlfile = open("gnubg.sql", "r")
> 

Seems fine.

> 1st fix explains why I was able to add matches to the db from the
> command line version of gnubg, but not from the gui version.

The command line version doesn't handle environments as far as I can
see, and I am not sure I understand how the gtk interface does.

Do you now where to place the test install. I could host it for a
limited period of time. As long as it was only announced here on this
list. Drop me a personal mail if you would like me to do so.

Christian.