[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnubg] Annoying popup when clicking through board designs
From: |
Philippe Michel |
Subject: |
Re: [Bug-gnubg] Annoying popup when clicking through board designs |
Date: |
Tue, 14 Jan 2014 00:20:23 +0100 (CET) |
User-agent: |
Alpine 2.00 (BSF 1167 2008-08-23) |
I don't know if this may be related to the problems at hand, but there are
some compiler warnings about DesignAdd() and RemoveDesign().
In the latter for instance, there is :
{
GList *plBoardDesigns = (GList *) data;
...
plBoardDesigns = g_list_remove(plBoardDesigns, pbdeSelected);
... <no use of plBoardDesigns>
DesignSave(pw, data);
}
- at the start, data and plBoardDesigns are identical, but after the
g_list_remove(), this may no longer be the case. What is saved may not be
what is expected.
- in plBoardDesigns = ..., do we really mean the local plBoardDesigns that
is not referenced after that (although maybe it should be, as argument of
DesignSave), or the global plBoardDesigns variable that is shadowed in
this function ?
The issues in DesignAdd() are similar.