[Bug-gnulib] HAVE_LIBINTL_H

[Bruno Haible]

Hi,

The HAVE_LIBINTL_H test in getopt.c, obstack.c, regex.c, error.c is
bogus. I propose to replace

     #if (HAVE_LIBINTL_H && ENABLE_NLS)

with

     #if ENABLE_NLS

Rationale: Many packages just use the gettext.m4 autoconf macros. They
define ENABLE_NLS if internationalization is requested and possible.
But HAVE_LIBINTL_H is not defined (and was never defined) by
gettext.m4. The result is that error messages from getopt are not
translated to the user's language at run time!

On the other hand, in packages not using gettext.m4 ENABLE_NLS will
not be defined, so even if the package's configure.in tests for the
existence of libintl.h, both preprocessor expressions evaluate to 0.

There might be one or two packages that could be affected by this
change, therefore I'd like to make this change first in gnulib and
push it to glibc a few months later when we are sure about it.

Opinions?

Bruno