[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] Re: stdbool.h.in

From: Jim Meyering
Subject: Re: [Bug-gnulib] Re: stdbool.h.in
Date: Fri, 06 Jun 2003 23:12:55 +0200

Bruno Haible <address@hidden> wrote:
> Jim Meyering wrote:
>> I'm reluctant because I'm not sure it's worth the maintenance hassle
>> of repeating the name
> Now to finish up with this tiny issue. Since I'm the maintainer of the module
> 'stdbool', I've committed your patch together with my desired modification.


Here's a similar change for alloca.
I remembered only after sending that patch for stdbool that using a
suffix (here, just `t') is better than using a prefix in general, because
sometimes $@ expands to a name including leading directory components.
And `t' is better than `-t' because it's one character shorter.

        * modules/alloca: Adjust Makefile snippet not to redirect directly
        to target.
        Use $(ALLOCA_H) notation, not @ALLOCA_H@ for AC_REPLACE'd variables.

Index: alloca
RCS file: /cvsroot/gnulib/gnulib/modules/alloca,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 alloca
--- alloca      20 Jan 2003 10:02:37 -0000      1.4
+++ alloca      6 Jun 2003 21:09:56 -0000
@@ -15,16 +15,16 @@ gl_FUNC_ALLOCA
 EXTRA_DIST += alloca_.h
-# The following is needed in order to create an <alloca.h> when the system
+# Create an <alloca.h> when the system
 # doesn't have one that works with the given compiler.
-all-local $(lib_OBJECTS): @ALLOCA_H@
+all-local $(lib_OBJECTS): $(ALLOCA_H)
 alloca.h: alloca_.h
-       cp $(srcdir)/alloca_.h alloca.h
+       cp $(srcdir)/alloca_.h address@hidden
+       mv address@hidden $@
+MOSTLYCLEANFILES += alloca.h alloca.ht
 #include <alloca.h>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]