[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-gnulib] suggestion

From: Jim Meyering
Subject: [Bug-gnulib] suggestion
Date: Sat, 07 Jun 2003 09:27:19 +0200

Hi Bruno,

I noticed you didn't apply parts of the recent stdbool patch.
Maybe you'd like some justification?

It is better to use $@ whenever possible,
to reduce duplication (ease maintenance).
It also shortens a long line, here.

sed's '<' is unnecessary.
Removing it also shortens the line.

And I've been taught that comments are best
written in the imperative.  In particular,
I try to avoid using the passive voice.

As for the `-t' vs. `t' suffix, I don't care much,
as long as we're consistent, but do have a slight preference
for the shorter one.


Index: stdbool
RCS file: /cvsroot/gnulib/gnulib/modules/stdbool,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 stdbool
--- stdbool     6 Jun 2003 20:59:34 -0000       1.7
+++ stdbool     7 Jun 2003 07:01:00 -0000
@@ -14,17 +14,15 @@ AM_STDBOOL_H
 EXTRA_DIST += stdbool_.h
-# The following is needed in order to create an <stdbool.h> when the system
-# doesn't have one that works.
+# Create stdbool.h on systems that lack a working one.
 all-local $(lib_OBJECTS): $(STDBOOL_H)
 stdbool.h: stdbool_.h
-       sed -e 's/@''HAVE__BOOL''@/$(HAVE__BOOL)/g' < $(srcdir)/stdbool_.h > 
-       mv stdbool.h-t stdbool.h
-MOSTLYCLEANFILES += stdbool.h stdbool.h-t
+       sed -e 's/@''HAVE__BOOL''@/$(HAVE__BOOL)/g' $(srcdir)/stdbool_.h > 
+       mv address@hidden $@
+MOSTLYCLEANFILES += stdbool.h stdbool.ht
 #include <stdbool.h>
 Bruno Haible

reply via email to

[Prev in Thread] Current Thread [Next in Thread]