Re: [Bug-gnulib] 03-getndelim2-c89.diff

[Derek Robert Price]

Bruno Haible wrote:

> Derek Robert Price wrote:
>  
>
> > -getloadavg (loadavg, nelem)
> > -     double loadavg[];
> > -     int nelem;
> > +getloadavg (double *loadavg, int nelem)
> >    
>
> I'd prefer   "double loadavg[]"
> because that's the way the libc documentation writes it, and the array
> has a fixed length.

Thanks for spotting this.  gcc's protoize function did this 
automatically.  I'll change it.

> > char *
> > -getusershell ()
> > +getusershell (void)
> >    
>
> There's absolutely no point is changing function _definitions_ with
> no arguments to use (void). Both ways to write it are equivalent from
> the language point of view, and (void) is just useless clutter for the
> human reader. Please drop this.

I think I James Youngman has a point.

> > __ptr_t
> > -__memchr (s, c_in, n)
> > -     const __ptr_t s;
> > -     int c_in;
> > -     size_t n;
> > +__memchr (const void *s, int c_in, size_t n)
> >    
>
> Why do you replace one instance of __ptr_t when you keep the other one?
>  

Again, gcc's protoize did this automatically and I'm guessing it must 
have been written to only rewrite the arguments portion of the function 
decls.  Thanks for spotting it.

In any case, void * is part of the C89 spec, isn't it?  How about I 
replace all the __ptr_t references with void *?

Derek

--
               *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
--
It is to secure our rights that we resort to government at all.

                        -Thomas Jefferson to M. D'Ivernois, 1795.