[Bug-gnulib] modules/fnmatch and alloca: proposed notation changes

[Jim Meyering]

For some time now, we've been able to rely on automake providing
a definition for each substituted variable.
As such, we should no longer use the @VAR@ notation.
Instead, use $(VAR).

It is important to reduce duplication just about everywhere,
including Makefile rules/commands.  The second part of this patch
does some of that.

Here are the proposed changes:

2003-08-09  Jim Meyering  <address@hidden>

        * modules/fnmatch: Use the `$(FNMATCH_H)' notation for AC_REPLACED
        variable names, rather than @address@hidden
        * modules/alloca: Likewise for $(ALLOCA_H).

        * modules/fnmatch (fnmatch.h): Use `$@' in the commands, in place of
        the three copies of the literal target, `fnmatch.h'.
        * modules/alloca (alloca.h): Likewise.

Index: modules/alloca
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/alloca,v
retrieving revision 1.6
diff -u -p -r1.6 alloca
--- modules/alloca      7 Jun 2003 16:41:48 -0000       1.6
+++ modules/alloca      9 Aug 2003 17:16:08 -0000
@@ -17,10 +17,10 @@ EXTRA_DIST += alloca_.h
 
 # We need the following in order to create an <alloca.h> when the system
 # doesn't have one that works with the given compiler.
-all-local $(lib_OBJECTS): @ALLOCA_H@
+all-local $(lib_OBJECTS): $(ALLOCA_H)
 alloca.h: alloca_.h
-       cp $(srcdir)/alloca_.h alloca.h-t
-       mv alloca.h-t alloca.h
+       cp $(srcdir)/alloca_.h address@hidden
+       mv address@hidden $@
 MOSTLYCLEANFILES += alloca.h alloca.h-t
 
 Include:
@@ -28,4 +28,3 @@ Include:
 
 Maintainer:
 address@hidden
-
Index: modules/fnmatch
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/fnmatch,v
retrieving revision 1.4
diff -u -p -r1.4 fnmatch
--- modules/fnmatch     7 Jun 2003 16:41:48 -0000       1.4
+++ modules/fnmatch     9 Aug 2003 17:16:08 -0000
@@ -19,10 +19,10 @@ EXTRA_DIST += fnmatch_.h fnmatch_loop.c
 
 # We need the following in order to create an <fnmatch.h> when the system
 # doesn't have one that supports the required API.
-all-local $(lib_OBJECTS): @FNMATCH_H@
+all-local $(lib_OBJECTS): $(FNMATCH_H)
 fnmatch.h: fnmatch_.h
-       cp $(srcdir)/fnmatch_.h fnmatch.h-t
-       mv fnmatch.h-t fnmatch.h
+       cp $(srcdir)/fnmatch_.h address@hidden
+       mv address@hidden $@
 MOSTLYCLEANFILES += fnmatch.h fnmatch.h-t
 
 Include:
@@ -30,4 +30,3 @@ Include:
 
 Maintainer:
 all, glibc
-