Re: [Bug-gnulib] invalid use of errno after ferror

[Paul Eggert]

> > Perhaps it would be better to let sleeping dogs lie, as the bug is not
> > that serious in this case, and it occurs only on older or nonstandard
> > systems.
> 
> The bug is "only" a possibly wrong error message...

Yes, that's what I meant.  If it's only the Microsoft Windows
platforms, I'm not sure its a high enough priority to worry about this
problem.  There are limits to how much we can make our code slower and
harder to maintain simply to make minor corrections to the wording of
some error messages on Microsoft Windows platforms.

Perhaps people who know well how to port to mingw and/or msvc can come
up with a solution that doesn't involve rewriting all our code,
e.g. by defining wrapper functions that do the right thing.  That
would be a win.  In the meantime I suspect that they can live with the
glitches in the error messages.

>       if (fprintf (output_file, "set ::msgcat::header ") < 0)
>         return -1;
> 
> and realized that the code had become unreadable and therefore unmaintainable.

But we already need to write that kind of code for each input operation.
Personally I'd just grit my teeth and check each output operation too.
I see your point, though; not everybody wants to do that.