[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] xgetdomainname.c should include stdlib.h

From: Bruno Haible
Subject: Re: [Bug-gnulib] xgetdomainname.c should include stdlib.h
Date: Mon, 19 Apr 2004 18:45:08 +0200
User-agent: KMail/1.5

Jim Meyering wrote:
> >  /* Get errno.  */
> >  #include <errno.h>
> > +
> > +/* Get free. */
> > +#include <stdlib.h>
> >
> >  #include "xalloc.h"
> BTW, wouldn't it be better without the `Get ...' comments?
> The `Get errno.' one certainly doesn't add anything useful.

Can you tell me one thing: When, after doing major changes to a source file,
you want to clean up the #includes, how do you do that without comments?

I've had the situation a few times where I asked myself whether <limits.h>
is still needed, searched for *_MIN and *_MAX values, found none, removed
the #include <limits.h> - and then got a compilation error because CHAR_BIT
wasn't found.

How do _you_ do such a cleanup?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]