[Bug-gnulib] including "stat-macros.h" in place of S_IS* and S_IF* definitions

[Jim Meyering]

There are currently many definitions of S_I* macros
in lib/*.c files.  Those definitions are all in stat-macros.h, now.
Does anyone object to removing the ad-hoc definitions and instead
merely doing `#include "stat-macros.h"' instead?

I've begun making such changes in coreutils:

2004-06-19  Jim Meyering  <address@hidden>

        * filemode.c: Remove all S_IS* and S_IF* definitions.
        Instead, just include "stat-macros.h".
        * stat.c: Likewise.
        * rmdir.c: Likewise.
        * makepath.c: Likewise.
        * lchown.c: Likewise.
        * isdir.c: Likewise.
        * canonicalize.c: Likewise.

        Add S_IS* definitions from filemode.c.
        * stat-macros.h (S_ISCTG): Define to zero if not already defined.
        (S_ISOFD): Likewise.
        (S_ISOFL): Likewise.