bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-gnulib] Minor cosmetic fix for gnulib-tool generated Makefile.am


From: Derek Robert Price
Subject: [Bug-gnulib] Minor cosmetic fix for gnulib-tool generated Makefile.am
Date: Sun, 10 Oct 2004 01:35:19 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616

I've attached a simple patch which fixes gnulib-tool to generate a
better looking lib/Makefile.am.

Briefly, it avoids adding blank spaces to lib/Makefile.am when the
Makefile.am section of the module description is actually empty and adds
a comment with the module name in front of other modules.  It also adds
a coupple blank lines I thought made it look better.  For example,
here's an excerpt from the center of a Makefile.am generated after
applying this patch:


MOSTLYCLEANFILES =
CLEANFILES =
DISTCLEANFILES =
MAINTAINERCLEANFILES =
                                                                               

## For module alloca:
BUILT_SOURCES += $(ALLOCA_H)
EXTRA_DIST += alloca_.h
                                                                               

# We need the following in order to create an <alloca.h> when the system
# doesn't have one that works with the given compiler.
all-local $(libgnu_a_OBJECTS): $(ALLOCA_H)
alloca.h: alloca_.h
        cp $(srcdir)/alloca_.h address@hidden
        mv address@hidden $@
MOSTLYCLEANFILES += alloca.h alloca.h-t
                                                                               

libgnu_a_LIBADD += @ALLOCA@
                                                                               

## For module alloca-opt:
BUILT_SOURCES += $(ALLOCA_H)
EXTRA_DIST += alloca_.h


and so on, again, with no empty space or comment generated for modules
like lstat which don't have Makefile.am text.

Cheers,

Derek

-- 
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!

Index: ChangeLog
===================================================================
RCS file: /cvsroot/gnulib/gnulib/ChangeLog,v
retrieving revision 1.196
diff -u -p -r1.196 ChangeLog
--- ChangeLog   5 Oct 2004 06:45:51 -0000       1.196
+++ ChangeLog   10 Oct 2004 05:24:22 -0000
@@ -1,3 +1,7 @@
+2004-10-10  Derek Price  <address@hidden>
+
+       * gnulib-tool: Cosmetic improvement for installed Makefile.am.
+
 2004-10-04  Paul Eggert  <address@hidden>
 
        * modules/xalloc (Files, Makefile.am): Remove xstrdup.c.
Index: gnulib-tool
===================================================================
RCS file: /cvsroot/gnulib/gnulib/gnulib-tool,v
retrieving revision 1.22
diff -u -p -r1.22 gnulib-tool
--- gnulib-tool 4 Oct 2004 11:44:19 -0000       1.22
+++ gnulib-tool 10 Oct 2004 05:24:23 -0000
@@ -771,12 +771,24 @@ case $mode in
            echo "CLEANFILES ="
            echo "DISTCLEANFILES ="
            echo "MAINTAINERCLEANFILES ="
+           echo
            for module in $modules; do
                func_verify_module
                if test -n "$module"; then
-                   func_get_automake_snippet "$module" | sed -e 
"s,lib_SOURCES,${libname}_${libext}_SOURCES,g" -e 
"s,lib_OBJECTS,${libname}_${libext}_OBJECTS,g"
+                   func_get_automake_snippet "$module" | sed -e "
+1{
+  s/^$//
+  Ti
+    d
+    bd
+  :i
+    i## For module $module:
+  :d
+}" -e "s,lib_SOURCES,${libname}_${libext}_SOURCES,g" -e 
"s,lib_OBJECTS,${libname}_${libext}_OBJECTS,g"
+
                    if test "$module" = 'alloca'; then
                        echo "${libname}_${libext}_LIBADD += @ALLOCA@"
+                       echo
                    fi
                fi
            done

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]