[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnulib] AUTOMAKE_OPTIONS = 1.5 gnits no-dependencies
From: |
Bruno Haible |
Subject: |
Re: [Bug-gnulib] AUTOMAKE_OPTIONS = 1.5 gnits no-dependencies |
Date: |
Fri, 15 Oct 2004 21:22:03 +0200 |
User-agent: |
KMail/1.5 |
Simon Josefsson wrote:
> After a recent CVS check out,
That was me: I removed some code duplication and organized the code into
shell functions, for maintainability.
> gnulib-tool --import generate the above
> AUTOMAKE_OPTIONS line. It used to be only '1.8 gnits'. Was this
> change done intentionally?
Yes: I don't see any feature being used that was not supported by automake 1.5.
(Since --import apparently does not create or modify m4/Makefile.am, there
is somewhere the assumption that automake >= 1.8 is used, but the right place
to state it is in the toplevel Makefile.am, or through a check in gnulib-tool,
not through lib/Makefile.am.)
> Disabling dependency tracking seem dangerous might it not risk not
> rebuilding some files after an --import inside an existing build tree?
I'd think people are clever enough to do a "make distclean", or at least a
"make clean", after --import. Do you think some developers are so sloppy
to not do "make clean" even after reimporting source code?
I don't like this dependency tracking because it adds so much shell
commands (clutter) to the "make" execution that it's hard to understand
what the Makefile is actually doing.
> Could we revert it?
If you think I'm wrong, yes, you can revert it.
Another point, that worries me more, is that you had @ALLOCA@ being added
to libfoo_la_LIBADD - which won't work on non-x86 platforms because alloca.o
is compiled without -fPIC and thus cannot work inside a shared library.
I changed it to @address@hidden But LTALLOCA needs to be defined somewhere;
probably in the generated gnulib.m4, like this:
changequote(,)dnl
LTALLOCA=`echo "$ALLOCA" | sed 's/\.[^.]* /.lo /g;s/\.[^.]*$/.lo/'`
changequote([, ])dnl
AC_SUBST(LTALLOCA)
Bruno