bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] Re: base64


From: Paul Eggert
Subject: Re: [bug-gnulib] Re: base64
Date: Sat, 27 Nov 2004 01:25:51 -0800
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

Simon Josefsson <address@hidden> writes:

>   size_t outlen = xsum (1, xtimes (xmax (inlen, inlen + 2) / 3, 4));

Sorry, I don't really follow this.  What is the xmax (inlen, inlen +
2) doing?  Why isn't it xsum (inlen, 2)?  Perhaps a comment would be
helpful, saying how many bytes you need (mathematically speaking) and
what the overflow checking is trying to do.  Personally I'd rather
avoid xsize.h entirely, but I can't suggest how to do that unless I
know what the code really wants to do here.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]