Re: [bug-gnulib] valloc()?

[Derek Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bruno Haible wrote:

| Is this all worth it? For what purpose do you need the memory to be
|  page-aligned?


That's a good question, as the original isn't my code.  I was just
assuming that whoever wrote it originally knew what they were doing.

There is only one place that CVS does this, and it is where it is
allocating new, empty buffer datas.  It later uses theres primarily in
calls to read() from various sources, from network pipes, exec pipes,
to files.

Looking at it, it mitigates the average 1/2 page lossage by allocating
16 * 4096 byte buffers at once, but this also means that it is not
making any attempt to force later buffer datas to be page aligned - if
this is compiled on a system with a page size greater than 4096, some
of the buffer datas will not be page aligned.  Is there any good
reason for doing this?  The buffers are saved and reused, and their
ordering is not preserved, so I wouldn't expect a great performance
advantage from doing this.

Regards,

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCJeIYLD1OTBfyMaQRAkYWAKC4ltX+X3gGVmHV2bidNWC1Z2Z2RQCgzern
32GIGKRl3OoOKZtFQbftwqI=
=g/7U
-----END PGP SIGNATURE-----