[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] gnulib-tool plays nice with make

From: Bruno Haible
Subject: Re: [bug-gnulib] gnulib-tool plays nice with make
Date: Fri, 4 Mar 2005 17:36:00 +0100
User-agent: KMail/1.5

Derek Price wrote:
> Is this what you had in mind?

This looks better, thanks. Three nits:

- Could you please make the function names start with 'func_' ? Just to
  make it clear to the reader that this is a function call, not a program
- Could you please document the functions with named arguments, like this?
      func_cp_if_changed src dest
  It is awful to have to peek inside a function in order to understand how
  to invoke it.
- Why this change?
  -  echo "Creating $destdir/$sourcebase/Makefile.am..."
  +  echo "Creating $destdir/$sourcebase/Makefile.am.new..."
  The user who watches gnulib-tool is not interested in temporary filenames,
  but in the final result. Also you don't echo the 'mv' later. Therefore it
  doesn't harm to let the user think that Makefile.am was actually created/


reply via email to

[Prev in Thread] Current Thread [Next in Thread]