bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] Re: [PATCH]: fix warning in the hash module


From: Yoann Vandoorselaere
Subject: Re: [bug-gnulib] Re: [PATCH]: fix warning in the hash module
Date: Wed, 18 May 2005 20:29:49 +0200

On Wed, 2005-05-18 at 16:16 +0100, Ian Abbott wrote:
> On 17/05/2005 10:20, Yoann Vandoorselaere wrote:
> > However, I still consider this version of the patch to be a hack, when
> > the real bug here is that you should not use const since you permit the
> > user to free() the data from the interface callback. The interface
> > should not use const at all.
> 
> Can you show how the Hash_data_freer callback is called from 
> hash_insert, because I can't see it!

It is not. The point was that the interface allow the user to specify a
callback for freeing the data, and thus the pointer to theses data
should not be marked as const.

-- 
Yoann Vandoorselaere <address@hidden>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]