bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] Re: should argp depend on unlocked-io?


From: Bruno Haible
Subject: Re: [bug-gnulib] Re: should argp depend on unlocked-io?
Date: Mon, 11 Jul 2005 13:21:39 +0200
User-agent: KMail/1.5

Sergey Poznyakoff wrote:
> Oskar Liljeblad <address@hidden> wrote:
> > Should argp depend on unlocked-io or should the line
> >
> >   AC_REQUIRE([gl_FUNC_GLIBC_UNLOCKED_IO])
> >
> > be removed from m4/argp.m4? If you keep it and don't
> > include unlocked-io along with argp, you'll get this
> > warning during automake:
>
> In my opinion it should depend on unlocked-io. Thanks for reporting.

What about this patch, then? Add the dependency to the module description.
It's then unnecessary to mention it in the autoconf macro.

2005-07-09  Bruno Haible  <address@hidden>

        * modules/argp: Depend on unlocked-io.
        * m4/argp.m4 (gl_ARGP): Remove dependency on unlocked-io's macro.

*** modules/argp.bak    2005-01-19 14:45:02.000000000 +0100
--- modules/argp        2005-07-10 00:20:06.000000000 +0200
***************
*** 27,32 ****
--- 27,33 ----
  strcase
  extensions
  vsnprintf
+ unlocked-io
  
  configure.ac:
  gl_ARGP
*** m4/argp.m4.bak      2005-01-26 17:51:24.000000000 +0100
--- m4/argp.m4  2005-07-10 00:20:38.000000000 +0200
***************
*** 1,5 ****
! # argp.m4 serial 4
! dnl Copyright (C) 2003, 2004 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
  dnl with or without modifications, as long as this notice is preserved.
--- 1,5 ----
! # argp.m4 serial 5
! dnl Copyright (C) 2003-2005 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
  dnl with or without modifications, as long as this notice is preserved.
***************
*** 7,13 ****
  AC_DEFUN([gl_ARGP],
  [
    AC_REQUIRE([AC_C_INLINE])
-   AC_REQUIRE([gl_FUNC_GLIBC_UNLOCKED_IO])
    AC_REQUIRE([gl_USE_SYSTEM_EXTENSIONS])
    AC_REQUIRE([gl_GETOPT_SUBSTITUTE])
    AC_CHECK_DECLS([program_invocation_name, program_invocation_short_name],,,
--- 7,12 ----





reply via email to

[Prev in Thread] Current Thread [Next in Thread]