bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: update minmax.m4


From: Bruno Haible
Subject: Re: update minmax.m4
Date: Thu, 25 Aug 2005 22:59:37 +0200
User-agent: KMail/1.5

Stepan Kasal wrote on 2005-06-30:
> I think it's time to re-submit my patch to minmax.m4.
> A new version of the patch is attached to this mail.
>
> Again, it features:
> > - use m4_pushdef/m4_popdef instead of define/undefine
>
> As I explained before, you cannot inadvertently undefine([HEADER]).

OK, I'm taking this.

> > - avoid the obsoleted AC_TRY_COMPILE
>
> Some people run "autoconf -W obsolete", and the macros from gnulib
> shouldn't spoil it.

There are dozens of AC_TRY_COMPILE invocations in gnulib's macros.
Nobody who uses "autoconf -W obsolete" complained about them so far,
and probably noone will until autoconf 3.0 really drops this macro or
emit serious warnings for its use.

I don't see why I should be the first one to engage in AC_TRY_COMPILE's
elimination.

> > - use AS_TR_* instead of raw m4_translit
>
> Do you see any problem with this patch?  All used macros are now
> documented.

Thanks, yes they are documented now. (Hope they won't be withdrawn before
autoconf-2.60 :-).) I applied this as well.

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]