Re: iconv_alloc for iconvme module

[Oskar Liljeblad]

On Monday, August 29, 2005 at 10:04, Simon Josefsson wrote:
[..]
> Same here, free may corrupt the errno from iconv (or others) that
> should be returned.

Thanks. I didn't know free could clobber errno. (Do you know a system
where it does?)

Another thing - I think you forgot to apply the iconvme.h patch.
See below. Without it, iconvme won't compile (no iconv_alloc
declaration).

> In the future, it will be easier to install if you suggest ChangeLog
> entries.

I'll try to remember that!

Regards,

Oskar

diff -u iconvme.h.v0 iconvme.h
--- iconvme.h.v0        2005-08-28 13:17:12.000000000 +0200
+++ iconvme.h   2005-08-28 13:33:31.000000000 +0200
@@ -22,4 +22,9 @@
 extern char *iconv_string (const char *string, const char *from_code,
                           const char *to_code);

+#if HAVE_ICONV
+# include <iconv.h>
+extern char *iconv_alloc (iconv_t cd, const char *string);
+#endif
+
 #endif /* ICONVME_H */