Re: config.h inclusion

[Paul Eggert]

Ralf Wildenhues <address@hidden> writes:

> 1) Fix the files that forgot to guard inclusion by HAVE_CONFIG_H.
>    This is the first patch.

Actually, I was thinking that we should go the other way, and include
config.h unconditionally (except for glibc-derived code).  As far as I
know, nobody outside of glibc uses this code without also defining
HAVE_CONFIG_H.  In the meantime let's leave this alone.

Also, now that I think about it I prefer "#if HAVE_CONFIG_H" to
"#ifdef HAVE_CONFIG_H".  (I don't know about other people.)  But if we
remove the #if for non-glibc code, we might as well stick to the glibc
convention for the glibc code.

> Do I have to contact each upstream source now?

For now I'd just leave it in bug-gnulib.

> -#if HAVE_CONFIG_H
> -# include <config.h>
> -#endif
> +/* You must include config.h before including this file. */

Let's omit the comment.  That's understood, in all gnulib source code.
(We can remove any instances of the comment that are already there.)