Re: [bug-gnulib] problems in stdbool.m4

[Bruno Haible]

Stepan Kasal wrote:
> I noticed two problems with stdbool.m4:
>
> Even with Autoconf-2.59, this file is included in aclocal.m4,
> and thus the gnulib definition overrides the Autoconf one.

This is what we want. Look at the comment:

------------------------------------------------------------------------------
  # This macro is only needed in autoconf <= 2.59.  Newer versions of autoconf
  # have this macro built-in.
  
  AC_DEFUN([AC_HEADER_STDBOOL],
  ...
------------------------------------------------------------------------------

The ChangeLog entry that corresponds to this change is:

2004-05-31  Paul Eggert  <address@hidden>

        * stdbool.m4 (AC_HEADER_STDBOOL): Detect _Bool bug in HP aC++/ANSI
        C B3910B A.05.55 [Dec 04 2003].  Problem reported by Jim Meyering.
        Also, fix a typo in a diagnostic.

> Perhaps the following would fix it:
>
> m4_ifndef([AC_HEADER_STDBOOL],
> AC_DEFUN([AC_HEADER_STDBOOL],
> [...
> ])
> ])

Nope, this would be a regression.

> Second, AM_STDBOOL_H is misnamed.  Wouldn't gl_STDBOOL_H be better?

To provide for a smooth transition from AM_STDBOOL_H to gl_STDBOOL_H,
I propose a three-step procedure:
  1) now, the appended patch,
  2) in a year, change modules/stdbool to require gl_STDBOOL_H,
  3) in two years, drop AM_STDBOOL_H.

Bruno


*** stdbool.m4  6 Oct 2005 16:44:39 -0000       1.6
--- stdbool.m4  12 Oct 2005 18:26:28 -0000
***************
*** 28,33 ****
--- 28,36 ----
    AC_SUBST([HAVE__BOOL])
  ])
  
+ # AM_STDBOOL_H will be renamed to gl_STDBOOL_H in the future.
+ AC_DEFUN([gl_STDBOOL_H], [AM_STDBOOL_H])
+ 
  # This macro is only needed in autoconf <= 2.59.  Newer versions of autoconf
  # have this macro built-in.