Re: des

[Ralf Wildenhues]

Hi Simon,

* Simon Josefsson wrote on Fri, Oct 14, 2005 at 01:23:25PM CEST:
> 
> Comments welcome, of course.

Typo nits:

> Index: lib/des.c
> ===================================================================
> RCS file: lib/des.c
> diff -N lib/des.c
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ lib/des.c 14 Oct 2005 11:23:02 -0000
> @@ -0,0 +1,683 @@

*snip*
> +/*
> + * Numbers of left shifts per round for encryption subkeys.
> + * To calculate the decryption subkeys we just reverse the
> + * ordering of the calculated encryption subkeys. So their

s/their/there/; I'd also do s/\. S/, s/

> + * is no need for a decryption rotate tab.
> + */
> +static const unsigned char encrypt_rotate_tab[16] = {
> +  1, 1, 2, 2, 2, 2, 2, 2, 1, 2, 2, 2, 2, 2, 2, 1
> +};
> +
> +/*
> + * Table with weak DES keys sorted in ascending order.
> + * In DES their are 64 known keys wich are weak. They are weak

s/their/there/

> + * because they produce only one, two or four different
> + * subkeys in the subkey scheduling process.
> + * The keys in this table have all their parity bits cleared.
> + */
*snip*

Cheers,
Ralf