[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: inet_ntop fix for mingw32
From: |
Simon Josefsson |
Subject: |
Re: inet_ntop fix for mingw32 |
Date: |
Tue, 17 Jan 2006 22:29:21 +0100 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) |
Bruno Haible <address@hidden> writes:
> Simon Josefsson wrote:
>> I installed this patch:
>>
>> Index: modules/socklen
>> ===================================================================
>> RCS file: /sources/gnulib/gnulib/modules/socklen,v
>> retrieving revision 1.2
>> retrieving revision 1.3
>> diff -u -p -r1.2 -r1.3
>> --- modules/socklen 15 Dec 2005 09:13:08 -0000 1.2
>> +++ modules/socklen 17 Jan 2006 17:22:37 -0000 1.3
>> @@ -12,6 +12,7 @@ gl_TYPE_SOCKLEN_T
>> Makefile.am:
>>
>> Include:
>> +#include <sys/socket.h>
>>
>> License:
>> unlimited
>
> Then 'socklen' should also have a dependency on 'sys_socket'.
I'm not sure. It gets ugly if no modules can assume sys/socket.h
without depending on sys_socket? Hmm.
OTOH, there aren't very many modules that need sys/socket.h. I think
it is fine for the modules below to depend on the sys_socket module,
if someone needs that. I need it for getaddrinfo and socklen, but I
won't touch the rest.
Yes, I'll make both getaddrinfo and socklen depend on sys_socket,
after I test things more. It seems there is some getaddrinfo support
in recent Win32 making things complicated to test for.
address@hidden:~/src/gnulib$ grep sys/socket.h m4/*.m4 lib/*.[ch]
m4/getaddrinfo.m4: sys/socket.h in i386-unknown-freebsd4.10 and
m4/getaddrinfo.m4:#include <sys/socket.h>
m4/getaddrinfo.m4:#include <sys/socket.h>
m4/socklen.m4: [AC_CHECK_HEADERS_ONCE([sys/socket.h ws2tcpip.h])
m4/socklen.m4: # include <sys/socket.h>
m4/socklen.m4: # include <sys/socket.h>
m4/sockpfaf.m4:#include <sys/socket.h>
m4/sockpfaf.m4: AC_DEFINE(HAVE_IPV4, 1, [Define to 1 if <sys/socket.h>
defines AF_INET.])
m4/sockpfaf.m4:#include <sys/socket.h>
m4/sockpfaf.m4: AC_DEFINE(HAVE_IPV6, 1, [Define to 1 if <sys/socket.h>
defines AF_INET6.])
m4/sys_socket_h.m4: AC_CHECK_HEADERS_ONCE([sys/socket.h])
m4/sys_socket_h.m4: SYS_SOCKET_H='sys/socket.h'
lib/getaddrinfo.h:/* sys/socket.h in i386-unknown-freebsd4.10 and
lib/getaddrinfo.h:# include <sys/socket.h>
lib/getloadavg.c:# include <sys/socket.h>
lib/inet_ntop.h:# include <sys/socket.h>
lib/poll.c:#include <sys/socket.h>
lib/socket_.h:/* Provide a sys/socket header file for systems lacking it (read:
mingw32).
lib/socket_.h: sys/socket.h. It is intended to provide definitions and
prototypes
lib/socket_.h: winsock2.h and ws2tcpip.h that declare the sys/socket.h
definitions
lib/stdbool_.h:/* BeOS <sys/socket.h> already #defines false 0, true 1. We use
the same
address@hidden:~/src/gnulib$
- Re: [bug-gnulib] Re: inet_ntop fix for mingw32, Bruno Haible, 2006/01/06
- Re: inet_ntop fix for mingw32, Simon Josefsson, 2006/01/09
- Re: [bug-gnulib] Re: inet_ntop fix for mingw32, Bruno Haible, 2006/01/09
- Re: inet_ntop fix for mingw32, Simon Josefsson, 2006/01/17
- Re: inet_ntop fix for mingw32, Bruno Haible, 2006/01/17
- Re: inet_ntop fix for mingw32,
Simon Josefsson <=
- Re: inet_ntop fix for mingw32, Bruno Haible, 2006/01/17
- Re: inet_ntop fix for mingw32, Simon Josefsson, 2006/01/18
- Re: inet_ntop fix for mingw32, Bruno Haible, 2006/01/18
- Re: inet_ntop fix for mingw32, Simon Josefsson, 2006/01/18
- socklen_t (was: Re: inet_ntop fix for mingw32), Simon Josefsson, 2006/01/19
- Re: inet_ntop fix for mingw32, Simon Josefsson, 2006/01/18