Re: socket.h

[Jim Meyering]

Simon Josefsson <address@hidden> wrote:
> For some reason, mingw32 uses non-POSIX names for shutdown's
...
> --- socket_.h 09 Jan 2006 17:13:09 +0100      1.1
> +++ socket_.h 19 Jan 2006 14:39:07 +0100
> @@ -34,4 +34,15 @@
> # include <ws2tcpip.h>
> #endif
>
> +/* For shutdown(). */
> +#if !defined(SHUT_RD) && defined (SD_RECEIVE)
> +# define SHUT_RD SD_RECEIVE
> +#endif
> +#if !defined(SHUT_WR) && defined (SD_SEND)
> +# define SHUT_WR 1
> +#endif
> +#if !defined(SHUT_RDWR) && defined (SD_BOTH)

Hi Simon,

Over the years, I've removed all unnecessary parentheses like the ones
above from nearly every file in coreutils.  This might be religious, but
I find that those parentheses provide no benefit.  Although coreutils
doesn't use that module, it might be worthwhile to start following the
same guideline in gnulib.

Any objection to removing them?

Index: lib/socket_.h
===================================================================
RCS file: /sources/gnulib/gnulib/lib/socket_.h,v
retrieving revision 1.2
diff -u -p -r1.2 socket_.h
--- lib/socket_.h       19 Jan 2006 13:45:37 -0000      1.2
+++ lib/socket_.h       23 Jan 2006 22:44:24 -0000
@@ -35,13 +35,13 @@
 #endif
 
 /* For shutdown(). */
-#if !defined(SHUT_RD) && defined (SD_RECEIVE)
+#if !defined SHUT_RD && defined SD_RECEIVE
 # define SHUT_RD SD_RECEIVE
 #endif
-#if !defined(SHUT_WR) && defined (SD_SEND)
+#if !defined SHUT_WR && defined SD_SEND
 # define SHUT_WR 1
 #endif
-#if !defined(SHUT_RDWR) && defined (SD_BOTH)
+#if !defined SHUT_RDWR && defined SD_BOTH
 # define SHUT_RDWR 2
 #endif