[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fts.c compilation error

From: Jim Meyering
Subject: Re: fts.c compilation error
Date: Thu, 26 Jan 2006 08:13:10 +0100

Paul Eggert <address@hidden> wrote:

> Jim Meyering <address@hidden> writes:
>> [Hmm.. I see I've also included the change adding O_NOCTTY and O_NONBLOCK.
>>  I'll update the ChangeLog entry to include that. ]
> But the change you checked in removed those rather than adding those.
> It also reintroduces the performance bug where we try to combine
> O_WRONLY | O_DIRECTORY, which always fails.  I assume this was
> inadvertent, and that this should be reverted.  Here's the part
> I'm talking about:
>> -  return open (dir, O_RDONLY | O_DIRECTORY | O_NOCTTY | O_NONBLOCK);
>> +  int fd = open (dir, O_RDONLY | O_DIRECTORY);
>> +  if (fd < 0)
>> +    fd = open (dir, O_WRONLY | O_DIRECTORY);
>> +  return fd;

Thanks for spotting that.
I'll deal with it in a few days, if you don't beat me to it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]