[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

rules, rules, and more (code policy) rules

From: Jim Meyering
Subject: rules, rules, and more (code policy) rules
Date: Wed, 08 Feb 2006 14:16:47 +0100

Simon Josefsson <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>> I tend to forget, too, so have automated quite a few policy checks,
>> over the years.  You might try adding some checks like those in coreutils'
>> Makefile.maint.  Here are the syntax-check (sc) target names:
> These are very useful tests.  I'd like to adopt them in my projects.
> Is there some way they could be moved to gnulib?  And perhaps
> modularize them somewhat.  For example, even if I currently use CVS
> for my projects, separating out the tests that assume CVS seems like a
> good idea.

Hi Simon,

Nearly all of those rules -- certainly the new ones -- require a version
control system.  For coreutils, I'm still using cvs, but it should be easy
to adapt to others.  The main functionality required is to be able to list
all of the version-controlled files so that we don't get false positives
on non-version-controlled (e.g., generated) files that happen to be in a
working directory.  Currently that's done by the build-aux/cvsu script.
Tweaking things to work also for svn, monotone, git, arch, mercurial, svk,
etc. shouldn't be hard.

You're welcome to generalize/modularize/whatever things and put the
result in gnulib.  Be aware that some of the rules enforce controversial
(to Bruno, at least :-) policies, so it may not be reasonable to apply
them to all of gnulib.  But that's why every rule has an exclusion mechanism.

Also, if you want to skip some of these syntax-check tests altogether,
just define a Make variable, local-checks-to-skip, and set it to the
corresponding list of rule names.

Hmm... I saw that the above wouldn't have worked the way I intended,
so I checked in this small change for coreutils/Makefile.maint:

        * Makefile.maint (local-checks-available): Define in terms of
        the expansion, $(syntax-check-rules), rather than the single,
        top-level target `syntax-check', so that it's easier to exclude
        individual rules (via $(local-checks-to-skip)).

> Scripts like gnupload, announce-gen, etc may also be useful to move to
> gnulib?

Sure!  It'd help us all stay in sync.  gnupload started in automake,
and is now used by quite a few other projects.  Plus, I know of
a few projects that are using older versions of announce-gen.

Have you just volunteered? :-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]