[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: base64.? going into rfc3548bis

From: Simon Josefsson
Subject: Re: base64.? going into rfc3548bis
Date: Fri, 24 Mar 2006 13:40:04 +0100
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

Ralf Wildenhues <address@hidden> writes:

> Hi Simon,
> * Simon Josefsson wrote on Fri, Mar 24, 2006 at 12:06:31PM CET:
>> FYI: The update of RFC 3548 will include lib/base64.?, so additional
>> review of these two files would be appreciated.
> If CHAR_BIT > 8, then an unsanitized array `in' as argument to
> base64_encode could read past the bounds of b64str.  I believe
> the patch below should fix this.

Hi Ralf!  This looks right to me, applied.

> If you're worried about the compiler not optimizing this away on
> systems with CHAR_BIT == 8 (which I have not checked), it would
> probably help to mask the input with 0x7f here.

I'm not worried about this until someone has profiling results that
indicate that it is a problem...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]