bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib changes to conform to Autoconf 2.59c rules for 'exit'


From: Eric Blake
Subject: Re: gnulib changes to conform to Autoconf 2.59c rules for 'exit'
Date: Mon, 24 Apr 2006 05:13:00 -0600
User-agent: Thunderbird 1.5.0.2 (Windows/20060308)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paul Eggert on 4/24/2006 1:38 AM:
> Autoconf 2.60 won't declare 'exit' for you automatically, due to severe
> portability hassles in trying to do this.  I installed the following
> changes to gnulib to accommodate this.  These changes also fix some
> related portability problems that I discovered in the neighborhood,
> e.g., other undeclared functions.

Mostly good.

> 
> Index: m4/unlink-busy.m4
> ===================================================================
> RCS file: /cvsroot/gnulib/gnulib/m4/unlink-busy.m4,v
> retrieving revision 1.5
> diff -p -u -r1.5 unlink-busy.m4
> --- m4/unlink-busy.m4 23 Jan 2005 08:06:57 -0000      1.5
> +++ m4/unlink-busy.m4 24 Apr 2006 07:34:27 -0000
> @@ -14,16 +14,16 @@ AC_DEFUN([gl_FUNC_UNLINK_BUSY_TEXT],
>    AC_CACHE_CHECK([whether a running program can be unlinked],
>      jm_cv_func_unlink_busy_text,
>      [
> -      AC_TRY_RUN([
> -        main (argc, argv)
> -          int argc;
> -          char **argv;
> -        {
> -          if (!argc)
> -            exit (-1);
> -          exit (unlink (argv[0]));
> -        }
> -     ],
> +      AC_RUN_IFELSE(
> +        [AC_LANG_SOURCE(
> +           [AC_INCLUDES_DEFAULT
> +         int
> +         main (argc, argv)
> +           int argc;
> +           char **argv;

However, why are you still using K&R here?  Doesn't gnulib assume C89 or
better; and shouldn't tests be made to work with C++ as a C compiler when
possible?

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFETLK884KuGfSFAYARAn+eAJ4jmjsJFL0/PQEWNmlsPSrYNusl9gCgpW3W
8BIgiNf4tR5hDKWgpV5it/s=
=pbaA
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]