bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: small inet_ntop.m4 fix


From: Yoann Vandoorselaere
Subject: Re: small inet_ntop.m4 fix
Date: Fri, 23 Jun 2006 12:07:54 +0200

On Wed, 2006-06-21 at 12:03 +0200, Simon Josefsson wrote:
> Simon Josefsson <address@hidden> writes:
> 
> > Yoann Vandoorselaere <address@hidden> writes:
> >
> >> On Sat, 2006-06-17 at 21:02 +0200, Simon Josefsson wrote:
> >>> Hi Yoann!  Ok to install this?  Gnulib assumes that sys/types.h
> >>> exists, and inet_ntop never tested HAVE_SYS_TYPES_H anyway.
> >>
> >> Hi Simon,
> >>
> >> Did you make sure that removing the sys/types.h requirement doesn't
> >> break the build on some platform, like FreeBSD 4.x ?
> >
> > Hi!  sys/types.h is still included by the source code, what I did was
> > to remove the autoconf test for sys/types.h, because the
> > HAVE_SYS_TYPES_H CPP symbol wasn't used and isn't needed.
> >
> > Gnulib assumes that sys/types.h exists on all platforms, so we
> > shouldn't test for it.
> 
> Hi Yoann, are you happy with my explanation?  Do you see any other
> problem with this patch?

Hi Simon,

Yes, please go ahead.
Regards,

-- 
Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technologies
Tel: +33 (0)8 70 70 21 58                  Fax: +33(0)4 78 42 21 58
http://www.prelude-ids.com





reply via email to

[Prev in Thread] Current Thread [Next in Thread]