bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: small inet_ntop.m4 fix


From: Simon Josefsson
Subject: Re: small inet_ntop.m4 fix
Date: Mon, 26 Jun 2006 10:54:52 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux)

Yoann Vandoorselaere <address@hidden> writes:

> On Wed, 2006-06-21 at 12:03 +0200, Simon Josefsson wrote:
>> Simon Josefsson <address@hidden> writes:
>> 
>> > Yoann Vandoorselaere <address@hidden> writes:
>> >
>> >> On Sat, 2006-06-17 at 21:02 +0200, Simon Josefsson wrote:
>> >>> Hi Yoann!  Ok to install this?  Gnulib assumes that sys/types.h
>> >>> exists, and inet_ntop never tested HAVE_SYS_TYPES_H anyway.
>> >>
>> >> Hi Simon,
>> >>
>> >> Did you make sure that removing the sys/types.h requirement doesn't
>> >> break the build on some platform, like FreeBSD 4.x ?
>> >
>> > Hi!  sys/types.h is still included by the source code, what I did was
>> > to remove the autoconf test for sys/types.h, because the
>> > HAVE_SYS_TYPES_H CPP symbol wasn't used and isn't needed.
>> >
>> > Gnulib assumes that sys/types.h exists on all platforms, so we
>> > shouldn't test for it.
>> 
>> Hi Yoann, are you happy with my explanation?  Do you see any other
>> problem with this patch?
>
> Hi Simon,
>
> Yes, please go ahead.

Done, thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]