bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AC_HEADER_STDC


From: Ralf Wildenhues
Subject: Re: AC_HEADER_STDC
Date: Thu, 6 Jul 2006 18:54:23 +0200
User-agent: Mutt/1.5.11-2006-07-05

* Bruno Haible wrote on Thu, Jul 06, 2006 at 02:51:10PM CEST:
> Paul Eggert wrote:
> 
> >     * m4/getusershell.m4 (gl_PREREQ_GETUSERSHELL): Remove; no longer needed.
> >     All uses removed.
> >     * m4/strtol.m4 (gl_PREREQ_STRTOL): Likewise.
> >     * m4/strtoul.m4 (gl_PREREQ_STRTOUL): Likewise.
> 
> I find it more maintainable to keep these macros, even when they are
> currently no-ops. Such as in m4/rename.m4. This eases things when some
> changes are made later to the lib/*.c file. Not having the distinction
> between the macro which tests whether a replacement function is needed
> and the macro which prepares for the replacement function itself is
> something that was confusing in the beginnings of gnulib, years ago.

To add to this, currently, modules/getusershell also still lists
| configure.ac:
| gl_PREREQ_GETUSERSHELL

This is wrong (and it shows as bogus output when testing this module).
But wasn't it wrong before and should have been this in the first place?

Cheers,
Ralf

        * modules/getusershell: Add gl_FUNC_GETUSERSHELL to
        configure.ac.

Index: modules/getusershell
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/getusershell,v
retrieving revision 1.6
diff -u -r1.6 getusershell
--- modules/getusershell        2 May 2005 07:00:50 -0000       1.6
+++ modules/getusershell        6 Jul 2006 16:53:08 -0000
@@ -10,7 +10,7 @@
 xalloc
 
 configure.ac:
-gl_PREREQ_GETUSERSHELL
+gl_FUNC_GETUSERSHELL
 
 Makefile.am:
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]