Re: create a big test, collect the fallout

[Paul Eggert]

Ralf Wildenhues <address@hidden> writes:

> 4) Documentation should not be copied into the source tree (bug in
>    getdate module; I'm inferring from other modules here) or the
>    gnulib-tool should 'mkdir doc' to avoid a cp failure.  OK?

My kneejerk reaction is I'd rather that gnulib-tool copied the
documentation correctly by default, or ignored the documentation on
user request.  I'd guess that most software that uses getdate should
document the date formats it accepts so I'd like to encourage
developers to include getdate.texi.


>       * m4/_inttypes_h.m4 (gl_INTTYPES_H): Use AC_CHECK_DECLS_ONCE
>       with only one argument.
>       * m4/fileblocks.m4 (gl_FILEBLOCKS): AC_CHECK_DECLS_ONCE may
>       expand to nothing, so add a shell command to avoid syntax error.
>       * m4/getpass.m4 (gl_FUNC_GETPASS): Likewise.

These look good, except the tradition is that the ":" should be put
into the PREREQ macros in case other callers run into the same
problem.  I installed the following.  Thanks.

2006-07-06  Ralf Wildenhues  <address@hidden>

        * _inttypes_h.m4 (gl_INTTYPES_H): Use AC_CHECK_DECLS_ONCE
        with only one argument, for Autoconf 2.60.
        * fileblocks.m4 (gl_PREREQ_FILEBLOCKS): AC_CHECK_DECLS_ONCE may
        expand to nothing, so add a shell command to avoid syntax error.
        * getpass.m4 (gl_PREREQ_GETPASS): Likewise.

Index: m4/_inttypes_h.m4
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/_inttypes_h.m4,v
retrieving revision 1.3
diff -p -u -r1.3 _inttypes_h.m4
--- m4/_inttypes_h.m4   4 Jul 2006 06:37:10 -0000       1.3
+++ m4/_inttypes_h.m4   6 Jul 2006 22:15:42 -0000
@@ -1,4 +1,4 @@
-# _inttypes_h.m4 serial 3
+# _inttypes_h.m4 serial 4
 dnl Copyright (C) 2006 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -12,5 +12,6 @@ AC_LIBSOURCES([inttypes.h])
 if test $gl_cv_have_include_next = no; then
   gl_ABSOLUTE_HEADER([inttypes.h])
 fi
-AC_CHECK_DECLS_ONCE([strtoimax strtoumax])dnl
+AC_CHECK_DECLS_ONCE([strtoimax])dnl
+AC_CHECK_DECLS_ONCE([strtoumax])dnl
 ])
Index: m4/fileblocks.m4
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/fileblocks.m4,v
retrieving revision 1.3
diff -p -u -r1.3 fileblocks.m4
--- m4/fileblocks.m4    23 Sep 2005 04:15:13 -0000      1.3
+++ m4/fileblocks.m4    6 Jul 2006 22:15:42 -0000
@@ -1,5 +1,5 @@
-# fileblocks.m4 serial 3
-dnl Copyright (C) 2002, 2005 Free Software Foundation, Inc.
+# fileblocks.m4 serial 4
+dnl Copyright (C) 2002, 2005, 2006 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
 dnl with or without modifications, as long as this notice is preserved.
@@ -16,4 +16,5 @@ AC_DEFUN([gl_FILEBLOCKS],
 # Prerequisites of lib/fileblocks.c.
 AC_DEFUN([gl_PREREQ_FILEBLOCKS], [
   AC_CHECK_HEADERS_ONCE(sys/param.h)
+  :
 ])
Index: m4/getpass.m4
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/getpass.m4,v
retrieving revision 1.12
diff -p -u -r1.12 getpass.m4
--- m4/getpass.m4       20 Apr 2006 22:28:34 -0000      1.12
+++ m4/getpass.m4       6 Jul 2006 22:15:42 -0000
@@ -1,4 +1,4 @@
-# getpass.m4 serial 7
+# getpass.m4 serial 8
 dnl Copyright (C) 2002-2003, 2005-2006 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -42,4 +42,5 @@ AC_DEFUN([gl_PREREQ_GETPASS], [
   AC_CHECK_DECLS_ONCE([fputs_unlocked])
   AC_CHECK_DECLS_ONCE([funlockfile])
   AC_CHECK_DECLS_ONCE([putc_unlocked])
+  :
 ])