Re: split stdio-safer into fopen-safer, tmpfile-safer

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paul Eggert on 7/25/2006 12:24 AM:
> With Bison I wanted fopen_safer but not tmpfile_safer (I think tmpfile
> is not that safe due to signals and whatnot), so I split the fopen-safer
> module into two, as follows:

Reasonable.  In fact, it means that people using "stdio--.h" now have the
added benefit of getting a link error if they use 'tmpfile' but did not
import the 'tmpfile-safer' module.  This can be construed as a feature to
make people avoid tmpfile.  (For the upcoming m4 1.4.6, it was too
invasive to a stable branch to rework the code to avoid tmpfile; but for
CVS head and the future m4 2.0, I agree with your sentiment that it is
better to avoid tmpfile).

Would you accept a similar patch that splits out pipe-safer into its own
module instead of part of unistd-safer?  Since pipe is not available on
mingw, I currently get compile-time warnings when compiling m4 on mingw,
but only because pipe-safer.c is using an undefined function, and not
because m4 is using pipe.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFExg+H84KuGfSFAYARAjTRAJ9O6fEd/QoXGLOYzr0c0OBe1r/I/wCbBR4S
HRjIx2cNaEKKqy0O80SYEXM=
=iBqO
-----END PGP SIGNATURE-----