Re: _LIBADD vs. _LDFLAGS

[Simon Josefsson]

Bruno Haible <address@hidden> writes:

> Hi Simon,
>
> I got an error message from the 'ar' command while using a lib_LIBADD
> augmentation. 'ar' doesn't like -L options. (You can observe this only
> when not using libtool to build the library.) The fix is to use lib_LDFLAGS
> instead. This is also precisely what's documented in the automake manual.
>
> Objections?

I recall having several problems in getting the proper libgcrypt flags
to be used when I added that stuff, but I don't recall what led me to
use that particular solution.  Please install the patch, if I run into
any problem later on, I'll report it then.

/Simon

> 2006-09-05  Bruno Haible  <address@hidden>
>
>       * modules/gc (Makefile.am): Augment lib_LDFLAGS, not lib_LIBADD.
>       * modules/iconvme (Makefile.am): Likewise. Also handle the case of
>       not using libtool correctly.
>
> diff -r -c3 gnulib-20060831/modules/gc gnulib-20060831-modified/modules/gc
> *** gnulib-20060831/modules/gc        2006-08-22 20:50:37.000000000 +0200
> --- gnulib-20060831-modified/modules/gc       2006-09-06 02:49:18.000000000 
> +0200
> ***************
> *** 16,24 ****
>   Makefile.am:
>   EXTRA_DIST += gc.h
>   if GL_COND_LIBTOOL
> ! lib_LIBADD += $(LTLIBGCRYPT)
>   else
> ! lib_LIBADD += $(LIBGCRYPT)
>   endif
>   
>   Include:
> --- 16,24 ----
>   Makefile.am:
>   EXTRA_DIST += gc.h
>   if GL_COND_LIBTOOL
> ! lib_LDFLAGS += $(LTLIBGCRYPT)
>   else
> ! lib_LDFLAGS += $(LIBGCRYPT)
>   endif
>   
>   Include:
> diff -r -c3 gnulib-20060831/modules/iconvme 
> gnulib-20060831-modified/modules/iconvme
> *** gnulib-20060831/modules/iconvme   2005-02-24 00:32:59.000000000 +0100
> --- gnulib-20060831-modified/modules/iconvme  2006-09-06 02:49:58.000000000 
> +0200
> ***************
> *** 15,21 ****
>   
>   Makefile.am:
>   lib_SOURCES += iconvme.h iconvme.c
> ! lib_LIBADD += $(LTLIBICONV)
>   
>   Include:
>   "iconvme.h"
> --- 15,25 ----
>   
>   Makefile.am:
>   lib_SOURCES += iconvme.h iconvme.c
> ! if GL_COND_LIBTOOL
> ! lib_LDFLAGS += $(LTLIBICONV)
> ! else
> ! lib_LDFLAGS += $(LIBICONV)
> ! endif
>   
>   Include:
>   "iconvme.h"