[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gnulib] unused variables and other nits in gnulib/m4
From: |
Bruno Haible |
Subject: |
Re: [bug-gnulib] unused variables and other nits in gnulib/m4 |
Date: |
Fri, 22 Sep 2006 22:12:21 +0200 |
User-agent: |
KMail/1.9.1 |
Ralf Wildenhues wrote:
> * lock.m4 (gl_LOCK_BODY): Avoid unused variables.
> * mbswidth.m4 (gl_MBSWIDTH): Likewise.
> * signed.m4 (bh_C_SIGNED): Likewise.
Thanks for the patches. I applied these, using Paul's usual
style "return !x;" (there's no reason for the 'if').
> * stpncpy.m4 (gl_FUNC_STPNCPY): Likewise.
Not applied. The patch does something different: It adds an include of
<string.h>. What's the point of that?
> * vasprintf.m4 (gl_FUNC_VASPRINTF): Require AC_GNU_SOURCE, so
> vasprintf is declared on GNU/Linux.
Done differently, to make it clear why this AC_GNU_SOURCE is needed.
Bruno