bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-tool: restore the ability to create a big testdir


From: Paul Eggert
Subject: Re: gnulib-tool: restore the ability to create a big testdir
Date: Thu, 12 Oct 2006 09:40:08 -0700
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

Bruno Haible <address@hidden> writes:

>   $ gnulib-tool --create-testdir --dir=/tmp/testdir `gnulib-tool --list`
> but this is no longer possible, since the config-h breaks a few other modules.

Would anybody object if I changed all the other modules to be
compatible with config-h?  The only downside is that gnulib would now
require packages to use AC_CONFIG_HEADERS, but all gnulib-using
packags that I know of already do this, so it's not much of a
downside.

The fix is straightforward and simplifies the code.  E.g., the
following patch suffices for the xstrndup module.  Also, if all the
other modules are changed this way, we could even remove the config-h
module, as it'd no longer be necessary.

--- lib/xstrndup.c      19 Sep 2005 17:28:15 -0000      1.3
+++ lib/xstrndup.c      12 Oct 2006 16:36:20 -0000
@@ -16,9 +16,7 @@
    along with this program; if not, write to the Free Software Foundation,
    Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.  */
 
-#ifdef HAVE_CONFIG_H
-# include <config.h>
-#endif
+#include <config.h>
 
 /* Specification.  */
 #include "xstrndup.h"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]