bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gcc warning in argmatch


From: Paul Eggert
Subject: Re: gcc warning in argmatch
Date: Thu, 19 Oct 2006 09:31:54 -0700
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

Bruno Haible <address@hidden> writes:

> !   error (0, 0,
> !      (problem == -1
> !       ? _("invalid argument %s for %s")
> !       : _("ambiguous argument %s for %s")),
> !      quotearg_n_style (0, ARGMATCH_QUOTING_STYLE, value),
>        quote_n (1, context));

That looks good, thanks, but can you please hoist the call to gettext
outside the conditional?  That is a tad easier for me to read and
typically generates more-compact code.  Something like this:

  error (0, 0,
         _(problem == -1
           ? "invalid argument %s for %s"
           : "ambiguous argument %s for %s"),
         quotearg_n_style (0, ARGMATCH_QUOTING_STYLE, value),
         quote_n (1, context));




reply via email to

[Prev in Thread] Current Thread [Next in Thread]