bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] Proposed Module: canonicalize-lgpl


From: Bruno Haible
Subject: Re: [bug-gnulib] Proposed Module: canonicalize-lgpl
Date: Mon, 6 Nov 2006 15:44:58 +0100
User-agent: KMail/1.9.1

Paul Eggert wrote:
> I guess the basic idea here is that we move this module from gettext
> to gnulib

Yes, this is the idea.

> Here is a slightly different proposal to add that module; it assumes
> the 'canonicalize' changes I just installed.  What do you think?

Looks fine. I too like the idea of sharing canonicalize.h.

Additionally, can we please add a comment here? The lack of a comment here,
together with the wrong comment in glibc-2.5's <stdlib.h>, confused me a lot.

Bruno


*** lib/canonicalize.h.bak      3 Nov 2006 23:17:27 -0000       1.4
--- lib/canonicalize.h  6 Nov 2006 14:44:47 -0000
***************
*** 39,45 ****
  # if HAVE_DECL_CANONICALIZE_FILE_NAME
  #  include <stdlib.h>
  # else
! char *canonicalize_file_name (const char *);
  # endif
  
  #endif /* !CANONICALIZE_H_ */
--- 39,48 ----
  # if HAVE_DECL_CANONICALIZE_FILE_NAME
  #  include <stdlib.h>
  # else
! /* Return a malloc'd string containing the canonical absolute name of the
!    named file.  If any file name component does not exist or is a symlink
!    to a nonexistent file, return NULL.  */
! extern char *canonicalize_file_name (const char *);
  # endif
  
  #endif /* !CANONICALIZE_H_ */




reply via email to

[Prev in Thread] Current Thread [Next in Thread]