bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] Re: NSK(OSS) compilation problem


From: Bruno Haible
Subject: Re: [bug-gnulib] Re: NSK(OSS) compilation problem
Date: Wed, 8 Nov 2006 21:45:27 +0100
User-agent: KMail/1.9.1

Paul Eggert wrote:
> Good.  That's what we want.  We want a test case that fails
> reliably on your platform but should succeed reliably on any
> conforming host.
> 
> I installed the following patch into gnulib and will install
> something similar into Autoconf shortly.

Thanks for finally clearing this up.

But the cross-compilation behaviour is changed: it now sets
  ac_cv_type_long_long_int=cross-compiling
and then also
  ac_cv_type_long_long=cross-compiling

which needs consequential changes at least in these places:

intmax_t.m4:22:    test $ac_cv_type_long_long = yes \
intmax_t.m4:55:    test $ac_cv_type_long_long = yes \
longlong.m4:68:  if test $ac_cv_type_long_long = yes; then
stdint.m4:16:  if test $ac_cv_type_long_long_int = yes; then
strtoll.m4:12:  if test "$ac_cv_type_long_long_int" = yes; then

Also, this will cause trouble in packages that use existing gnulib
macros (such as gettext of any version <= 0.16) if they reconfigure it
with a newer autoconf.

Since the comment already says that when cross-compiling we can assume
that the bug is not present, I'd propose to set ac_cv_type_long_long_int
to the value it had before:

2006-11-08  Bruno Haible  <address@hidden>

        * m4/longlong.m4 (AC_TYPE_LONG_LONG_INT): Set ac_cv_type_long_long_int
        to 'yes' instead of 'cross-compiling'.

*** m4/longlong.m4      8 Nov 2006 06:21:38 -0000       1.11
--- m4/longlong.m4      8 Nov 2006 20:45:43 -0000
***************
*** 1,4 ****
! # longlong.m4 serial 9
  dnl Copyright (C) 1999-2006 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
--- 1,4 ----
! # longlong.m4 serial 10
  dnl Copyright (C) 1999-2006 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
***************
*** 52,60 ****
               return 0;]])],
          [ac_cv_type_long_long_int=yes],
          [ac_cv_type_long_long_int=no],
!         [ac_cv_type_long_long_int=cross-compiling])],
         [ac_cv_type_long_long_int=no])])
!   if test $ac_cv_type_long_long_int != no; then
      AC_DEFINE([HAVE_LONG_LONG_INT], 1,
        [Define to 1 if the system has the type `long long int'.])
    fi
--- 52,60 ----
               return 0;]])],
          [ac_cv_type_long_long_int=yes],
          [ac_cv_type_long_long_int=no],
!         [ac_cv_type_long_long_int=yes])],
         [ac_cv_type_long_long_int=no])])
!   if test $ac_cv_type_long_long_int = yes; then
      AC_DEFINE([HAVE_LONG_LONG_INT], 1,
        [Define to 1 if the system has the type `long long int'.])
    fi




reply via email to

[Prev in Thread] Current Thread [Next in Thread]