bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: inline.m4: use compiler, not cpp


From: Jim Meyering
Subject: Re: inline.m4: use compiler, not cpp
Date: Fri, 10 Nov 2006 15:53:42 +0100

Bruno Haible <address@hidden> wrote:

> Jim Meyering wrote:
>> 2006-11-10  Jim Meyering  <address@hidden>
>>
>>      * m4/inline.m4 (gl_INLINE): Check with the compiler, not cpp,
>>      so that relevant options in CFLAGS (like -O, -fno-inline) are
>>      taken into account.
>
> Thanks again! I applied this patch, with added comments, and without
> the quadrigraphs for '#'. (It works with '#' therefore why write '@%:@'?)

Indeed.  Better not to blindly follow old examples :-)

>> The gl_INLINE macro was failing to define HAVE_INLINE,
>> and that led to link errors when building coreutils with CFLAGS=-O.
>
> Hmm. I understand such link errors if, after updating from gnulib, you
> did "make" without "make clean". If you got the link errors also after doing
> a "make clean; make", there must still be an error somewhere. The HAVE_INLINE
> is only a hint. Do you still get a link error when configuring and compiling
> with no optimization (CFLAGS empty)?

I did not run "make clean", but did ensure that config.h was updated.
That alone should have caused all "old" .o files to be rebuilt, but there
is a bug (haven't investigated at all yet) whereby most of the generated
dependencies (lib/.deps/*.Po files) are not included into the Makefile.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]